feat(ci): reusable secret-scan workflow + secret-scanning rule#663
Closed
JacobPEvans-personal wants to merge 1 commit into
Closed
feat(ci): reusable secret-scan workflow + secret-scanning rule#663JacobPEvans-personal wants to merge 1 commit into
JacobPEvans-personal wants to merge 1 commit into
Conversation
Layer 3 + Layer 0 of the multi-layer sensitive-value prevention system. - .github/workflows/secret-scan.yml: reusable (workflow_call) template other dryvist repos invoke. Two prongs — structural gitleaks (official container, no org-license needed) driven by the caller's .gitleaks.toml, and a literal SENSITIVE_DENYLIST scan over the PR's changed files. Fail-closed on missing secret (non-fork), graceful skip on forks; patterns masked; path-only reporting. - .github/scripts/sensitive-denylist-scan.sh: the literal-scan script, sparse checked-out by consumers so they need zero local copies. - agentsmd/rules/secret-scanning.md: auto-loaded rule documenting the 4 layers and the SENSITIVE_DENYLIST contract. Sibling PRs: terraform-proxmox#339 (pre-commit + CI), claude-code-plugins#338 (secret-guard PreToolUse hook). Assisted-by: Claude:claude-opus-4-8
Member
Author
|
Closing per maintainer: NO custom scripts. The reusable workflow relied on a bespoke denylist scan script — rejected. gitleaks-only approach instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Layers 3 + 0 of the multi-layer system that blocks real homelab values from public repos.
.github/workflows/secret-scan.yml— reusable (workflow_call) template other dryvist repos invoke. Two prongs:gitleaks-actionorg-license needed), driven by the caller's.gitleaks.toml.SENSITIVE_DENYLISTGH-secret over the PR's changed files. Fail-closed on missing secret (non-fork), graceful skip on forks, patterns::add-mask::ed, path-only reporting (never the value)..github/scripts/sensitive-denylist-scan.sh— the literal-scan script.agentsmd/rules/secret-scanning.md— auto-loaded rule documenting the 4 layers + theSENSITIVE_DENYLISTcontract.Verification
shellcheckclean; YAML valid;markdownlint+ link-check +pre-commitgreen.env:; least-privilegepermissions: contents: read.Sibling PRs (same effort)
dryvist/terraform-proxmox#339— pre-commit hooks + CI (self-contained; migrates to this template later)dryvist/claude-code-plugins#338— Layer 1secret-guardPreToolUse hook🤖 Generated with Claude Code