Skip to content

chore: drop URL output requirement from PR status summary #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacobPEvans-personal wants to merge 1 commit into from
Closed

chore: drop URL output requirement from PR status summary #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions github-workflows/skills/gh-cli-patterns/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,24 +191,24 @@ skill that emits a summary — do NOT define local output formats in individual
```text
{Title}
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✅ https://github.com/<OWNER>/<REPO>/pull/42 Ready for review
🟡 https://github.com/<OWNER>/<REPO>/pull/43 CI pending
🔴 https://github.com/<OWNER>/<REPO>/pull/44 Conflicts | 3 open comments
✅ #42 Ready for review
🟡 #43 CI pending
🔴 #44 Conflicts | 3 open comments
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

All Open PRs — <OWNER>/<REPO>
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✅ https://github.com/<OWNER>/<REPO>/pull/42 Ready for review
🟡 https://github.com/<OWNER>/<REPO>/pull/43 CI pending
🔴 https://github.com/<OWNER>/<REPO>/pull/44 Conflicts | 3 open comments
✅ #42 Ready for review
🟡 #43 CI pending
🔴 #44 Conflicts | 3 open comments
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Ready to merge (1):
/squash-merge-pr 42 (<OWNER>/<REPO>)

Blocked — needs human (2):
https://github.com/<OWNER>/<REPO>/pull/43 — CI pending
https://github.com/<OWNER>/<REPO>/pull/44 — Conflicts | 3 open comments
#43 — CI pending
#44 — Conflicts | 3 open comments
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
```

Expand All @@ -228,7 +228,7 @@ Blocked — needs human (2):

### Status tags

Append after the URL, separated by ` | `. Omit when no issues exist ("Ready for review" suffices).
Append after the PR number, separated by ` | `. Omit when no issues exist ("Ready for review" suffices).
Comment thread
JacobPEvans-personal marked this conversation as resolved.

| Tag | Section 1 trigger | Section 2 trigger |
|-----|-------------------|-------------------|
Expand All @@ -244,12 +244,6 @@ Append after the URL, separated by ` | `. Omit when no issues exist ("Ready for

### Data queries

**Fetch PR URL** (for Section 1 — current PRs):

```bash
gh pr view <PR_NUMBER> --json url --jq '.url'
```

**Fetch all open PRs** (for Section 2 — one GraphQL call per affected repo):

`gh pr list --json` does NOT support `mergeStateStatus` — use GraphQL instead:
Expand All @@ -260,7 +254,7 @@ gh api graphql -f query='
repository(owner:$owner,name:$repo){
pullRequests(states:OPEN,first:50){
nodes{
number url title mergeable reviewDecision mergeStateStatus isDraft
number title mergeable reviewDecision mergeStateStatus isDraft
commits(last:1){nodes{commit{statusCheckRollup{state}}}}
}
}
Expand Down
6 changes: 1 addition & 5 deletions github-workflows/skills/ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,7 @@ If any abort condition hits: re-invoke `/finalize-pr <PR_NUMBER>`, wait for comp
then re-run both gates. Only list a PR as "Ready to merge" after both gates pass.

Then emit the **Canonical PR Status Summary** as defined in /gh-cli-patterns, titled
`Ship Summary`. Affected repos = current repo. Fetch each PR's full URL via:

```bash
gh pr view <PR_NUMBER> --json url --jq '.url'
```
`Ship Summary`. Affected repos = current repo.

Section 1 lists the PRs targeted by this `/ship` invocation. Section 2 lists all open
PRs in the current repo (including unrelated ones).
Expand Down
Loading