fix: pass App ID from vars not secrets in release-please#20
Merged
Conversation
The GH_ACTION_JACOBPEVANS_APP_ID value is stored as a repository variable, not a secret. Passing it via secrets.* resolved to empty string, causing every release-please run since 2026-04-25 to fail with "client-id must be set to a non-empty string". Also update configs/LAYOUT.md to drop the stale pip install .[vllm] reference — that optional extra was removed in #19 (CVE cleanup); vllm runs on a separate Linux/CUDA host. (claude)
There was a problem hiding this comment.
Pull request overview
Fixes the release-please workflow by passing the GitHub App ID from repository variables (where it’s actually stored) instead of secrets, and updates layout documentation to remove a stale local vllm install note.
Changes:
- Update
release-pleasereusable-workflow secret mapping to use${{ vars.GH_ACTION_JACOBPEVANS_APP_ID }}. - Update
configs/LAYOUT.mdto reflect thatvllmthroughput benchmarking runs on an external host (no local install).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Fixes the workflow configuration so actions/create-github-app-token receives a non-empty App ID. |
configs/LAYOUT.md |
Removes outdated guidance about installing a removed [vllm] extra; aligns docs with external-host setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install .[vllm]note in LAYOUT.mdRoot cause
GH_ACTION_JACOBPEVANS_APP_IDis stored as a repo variable (not asecret). The caller was passing
${{ secrets.GH_ACTION_JACOBPEVANS_APP_ID }},which resolves to empty — causing
actions/create-github-app-tokento failimmediately with "client-id must be set to a non-empty string".
Changes
.github/workflows/release-please.yml:secrets.GH_ACTION_JACOBPEVANS_APP_ID→
vars.GH_ACTION_JACOBPEVANS_APP_ID(one character change)configs/LAYOUT.md: updated vllm comment to note external host (the[vllm]optional extra was removed in fix: pin pillow + orjson in space/, bump base version to 0.4.0 #19)Test plan
gh run list --workflow=release-please.ymlshowssuccess🤖 Generated with Claude Code