Fix no-MCP Workbench isolate hang; agents use discover then confirm - #14
Merged
Conversation
CLI isolate no longer blocks on System.in when stdin is not a TTY, so Maven one-shot isolate cannot hang or start-then-stop a worker. Pointers and AGENT-GUIDE now show the Maven exec wrapper and reserve live isolate for an already-running Workbench. Co-authored-by: ds-code-t <ds-code-t@users.noreply.github.com>
Gradle test JVMs can have a console even when Maven exec stdin is a pipe. Isolate now takes an explicit interactive-stdin flag, treats console-null or non-tty fd 0 as non-interactive, and the unit test drives that path directly. Co-authored-by: ds-code-t <ds-code-t@users.noreply.github.com>
ds-code-t
marked this pull request as ready for review
August 27, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship blocker on
2.1.10: CLIisolateis not agent-completable. Maven exec from Copilot has non-TTY stdin, soSystem.in.read()either hangs until killed or starts a paused worker and immediately stops it. AGENT-GUIDE still told agents to isolate thenworkbench_execute_stepeven with noworkbench_*tools.This change makes the no-MCP path discover then confirm. Live isolate stays only for an already-running Workbench (pre-attached
workbench_*or interactive TTY).Functionality-change coverage
AGENTS.mdand the relevant feature-map entry.docs/agent/feature-map.mdremains accurate.docs/agent/repository-index.mdis current.Behavior
isolate: if stdin is not an interactive TTY andpickleball.workbench.isolate.onceis unset, do not start a worker or block onSystem.in.read(). Print that live isolate needs an already-running Workbench,NEXT: confirm --tags/--name, exit 2.pickleball.workbench.isolate.onceis unchanged.AGENTS.md/.github/copilot-instructions.mdstay identical (3 nonblank lines): export-guidance via Workbench launcher;hint/discover/confirm; isolate only ifworkbench_*already in session; no GUI; do not register IDE MCP.-Dexec.mainClass=tools.dscode.launcher.PickleballWorkbenchLauncher, change-Dexec.args). It does not tell agents to Maven-exec isolate whenworkbench_*is absent.docs/pickleball-workbench.mdno longer callsmcp <project>the consumer-agent path. GradlepickleballWorkbenchexample defaults tohint, notmcp.@agent-pointer-evalstays maintainer-only at the bottom. Canned eval failures were not changed.ParallelCountEstimator.recommendedDiscoverRunVarsusesAgentBrowserLadderso a remote project browser is not overwritten withCHROME_HEADLESS.Pointer text (
maven-consumer-project/AGENTS.mdand.github/copilot-instructions.md, identical)Validation
python3 scripts/verify_agent_contract.pypython3 scripts/refresh_agent_index.py --check./gradlew test./gradlew publishToMavenLocal./maven-consumer-project/mvnw -f maven-consumer-project/pom.xml -U test -Dpkb_runvars.pkb_browser=CHROME_HEADLESS -Dpkb_runvars.pkb_tags="@diagnostic-reporting or @diagnostic-single"(2 scenarios, 0 failures). Not@all.No version bump. PR targets
2.1.10only, notmaster.