Fix Workbench Play stall after the first live step - #4
Merged
Conversation
executeStep already advances the RUNNING playhead; the Swing Play loop was marking the same captured step again, which threw after playbackBusy was cleared and skipped the next schedulePlaybackStep. Keep executeStep as the single playhead owner, make leftover marks no-ops, and continue automatic playback while RUNNING. Co-authored-by: ds-code-t <ds-code-t@users.noreply.github.com>
ds-code-t
marked this pull request as ready for review
August 24, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workbench UI Play ran the first live demo step (
Given navigate to: URL.home) and then looked paused because the playhead was advanced twice:WorkbenchController.executeStepfollowed the RUNNING playhead viamaybeAdvancePlayhead.WorkbenchFrame.schedulePlaybackStepthen calledmarkCurrentStepExecutedon the captured first-step id. After step 1 that id was no longer current, sorequireCurrentStepthrew. The throw happened afterplaybackBusy = falseand beforeschedulePlaybackStep()for the next line, so automatic playback died.This change keeps
executeStepas the single playhead owner (needed for attached-agent/MCP spectator follow). The Swing Play loop refreshes and continues whileRUNNINGwithout remaking that mark. LeftovermarkCurrentStepExecuted/markCurrentStepFailedcalls on an already-consumed id are no-ops, so they cannot abort playback. Isolated Step still pauses first. At end the player still staysWAITING_FOR_STEP.Functionality-change coverage
AGENTS.mdand the relevant feature-map entry.docs/agent/feature-map.mdremains accurate.docs/agent/repository-index.mdis current.Validation
python3 scripts/verify_agent_contract.pypython3 scripts/refresh_agent_index.py --checkpython3 scripts/sync_consumer_guidance.py --check./gradlew :pickleball-workbench:test(BUILD SUCCESSFUL)./gradlew test(full root suite not requested)./gradlew publishToMavenLocal./maven-consumer-project/mvnw -f maven-consumer-project/pom.xml -U test -Dpkb_browser=CHROME_HEADLESSNot running
@allCucumber, full roottest, or Maven consumer@all, per the Workbench playback-stall request.