This repository was archived by the owner on Aug 27, 2025. It is now read-only.
feat(semgrep): allow semgrep supressions#31
Open
vincetyy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Currently, the Semgrep workflow shows all issues even if they are supposed to be suppressed by
# nosemgrepor// nosemgrep. This is because the sarif file generated by the Semgrep command includes ignored findings as well.Description
Added a check for
suppressionsin the sarif file and skips the issue if there is. Additionally, the surpressed issues are still listed in the issue itself.How has this been tested?