Skip to content

Moved existing unit tests to standard folder structure#15

Open
ChrisLGardner wants to merge 2 commits into
dsccommunity:devfrom
ChrisLGardner:move-tests
Open

Moved existing unit tests to standard folder structure#15
ChrisLGardner wants to merge 2 commits into
dsccommunity:devfrom
ChrisLGardner:move-tests

Conversation

@ChrisLGardner
Copy link
Copy Markdown
Contributor

@ChrisLGardner ChrisLGardner commented Dec 1, 2017

Moved them in line with the other DSC modules.

VSCode also appears to have tidied up all the random whitespace which is screwing up the diff.


This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Apr 25, 2018
@regedit32
Copy link
Copy Markdown
Member

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Tests/Unit/WinEvent.Tests.ps1, line 6 at r1 (raw file):

Import-Module $PSScriptRoot\..\..\DSCResources\MSFT_xWinEventLog\MSFT_xWinEventLog.psm1

Style guidelines suggests we should not use backslashes within paths. The unit test template has changed a lot since this was created. Perhaps we should align with the current template since you're updating it.


Comments from Reviewable

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels May 3, 2018
@johlju
Copy link
Copy Markdown
Member

johlju commented May 23, 2018

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 23, 2018
@gaelcolas
Copy link
Copy Markdown
Member

Hey @ChrisLGardner any chance you could fix that one? It could do with a rebase as well :)

@gaelcolas gaelcolas added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed abandoned The pull request has been abandoned. labels Mar 15, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 15, 2019

Codecov Report

Merging #15 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #15   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files           2        2           
  Lines          65       65           
=======================================
  Hits           45       45           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05f8bb...e930df7. Read the comment docs.

@ChrisLGardner
Copy link
Copy Markdown
Contributor Author

Rebase done. I'll find some time to fix the way it's importing the module etc to use the standard format and make use of the standard tests etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants