Repository navigation
chore(deps): bump thruster from 0.1.26 to 0.1.27 - #1399
Merged
Merged
Conversation
Bumps [thruster](https://github.com/basecamp/thruster) from 0.1.26 to 0.1.27. - [Changelog](https://github.com/basecamp/thruster/blob/main/CHANGELOG.md) - [Commits](basecamp/thruster@v0.1.26...v0.1.27) --- updated-dependencies: - dependency-name: thruster dependency-version: 0.1.27 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dschmura
added a commit
that referenced
this pull request
Oct 16, 2026
…#1410) The image scan has been red on `main` since its weekly run on 2026-10-12, and on every pull request that touches `Gemfile.lock` since (#1394, #1395, #1399, #1408): four HIGH findings in the Go baked into Thruster's precompiled binary — Go stdlib v1.27.1 and `golang.org/x/net` v0.59.0, three denial-of-service CVEs fixed only in Go 1.27.2 and x/net 0.60.0. Thruster 0.1.27 is the newest release, and its published x86_64-linux binary reports `go1.27.1`, so no version of Thruster carries the fix yet. The `.trivyignore` entry for Thruster's Go named its own revisit trigger: "on the next thruster release (> 0.1.26), or 2026-10-15". Both fired. This does what that trigger asked. Thruster moves to 0.1.27, the three new findings go in with the same reasoning the previous batch used — no fixed release exists, so there is no action to take regardless of reachability — and a new trigger: the next release after 0.1.27, or 2026-11-15. The eight go1.26.5-era CVEs the block held, all fixed in Go 1.26.6 and later, are removed rather than carried forward. The scan cannot print a finding it ignores, so the only way to learn whether go1.27.1 cleared them is to stop ignoring them: **this pull request's Image Scan is that proof**, and a finding that comes back goes back in with its own reason. Exposure, for the record and not as the rationale: Thruster terminates TLS only when `TLS_DOMAIN` is set, and no tracked file sets it (`git grep TLS_DOMAIN` is empty); a fork that enables TLS does so in kamal-proxy (`proxy: ssl: true`, shipped commented out in `config/deploy.yml`). That bears on the crypto/tls finding. Whether the http2 path is reachable through kamal-proxy was not verified. ## Verification - The three CVEs, versions and fixed versions read from #1408's failed scan (run 38798151407): stdlib v1.27.1 → 1.27.2 for 78667, 78669, 97031; x/net v0.59.0 → 0.60.0 for 78669. - `go1.27.1` read from the binary in the published `thruster-0.1.27-x86_64-linux` gem. - `.trivyignore` and image-scan invariants: 6 examples, 0 failures (rationale and `Revisit:` marker present). - Image Scan on this pull request (run 38811378629): **green**, and it did scan the binary — the `thruster-0.1.27-x86_64-linux/exe/x86_64-linux/` target is listed as `gobinary`, 0 findings — so none of the eight retired entries is still present and the three new ones are the only findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps thruster from 0.1.26 to 0.1.27.
Changelog
Sourced from thruster's changelog.
Commits
669643fMerge commit from fork38d3721Merge pull request #155 from erikthoreson24/version-0.1.270992970Bump version72796d7Merge pull request #154 from basecamp/deps0864e8aUse http.Transport for h2c test client80e89eeUpdate dependencies22a9978Merge pull request #152 from erikthoreson24/fix/bump-x-crypto-0.56.0b186518Bump golang.org/x/crypto to v0.56.03ef8516Merge pull request #150 from basecamp/go-1.27.1fa31b96Add make check to run go vet and govulncheckDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)