fix(vision): preserve native image blocks during handoff - #2
Merged
Gu-ZT merged 1 commit intoSep 6, 2026
Merged
Conversation
Collaborator
|
已审查并以 squash 合并(e497aa5)。感谢贡献! 评审确认的三处真实修复:
本地复核: 两个非阻塞的后续建议:
关于 PR 描述里提到的核心契约(把准备后的路由/能力发布给提示词装配、请求生命周期的工具限制、session-logged 图片引用投影挂接点):方向认同,欢迎到 dsh 主仓开 issue 讨论。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageBlocks for exact request routes that declare image inputdescribe_imagereferences only for text-only or undeclared routesRoot cause
The v0.6.4 handoff listener treated every non-auxiliary route as text-only. It never resolved the exact request route’s real modalities, so native vision models were downgraded to text references. Its global re-entry flag and resolver replacement also made concurrent streams and teardown fragile, while inflating the configured auxiliary route could hide an invalid vision selection.
Validation
npm run typechecknpm test(14/14)npm pack --dry-run --json --cache .npm-cachegit diff --checkScope / follow-up
This remains a plugin-only fix and uses no private
agent/request-surfaceAPI. The existingskipWhenMainModelSupportsImageoption remains a generic prompt-assembly approximation.Exact per-attempt Auto/Always/Disabled visibility needs a Harness core contract exposing the prepared route/capabilities and request-lifetime tool restriction/guard lifecycle.
Because the released
llm/streamcontract describes loop request content as read-only, a fully first-class handoff should also gain a core-owned, session-logged image-reference projection/admission hook. This PR hardens the compatibility shim already shipped in v0.6.4.