Repository navigation
feat(auth): a message on the login page - #68
Merged
Merged
Conversation
Auth\LoginNotice::put($message, $tone) leaves a reason for the login page — why an external sign-in turned someone away — and the next bootstrap takes it (`loginNotice`); LoginForm shows it once above the form. Kept in the session rather than flashed, so it survives the xhr bootstrap strategy too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second piece of groundwork for SSO (printable ADR-038), still protocol-free: when an external sign-in turns someone away (no mapped role, an email conflict, the provider down), the package redirects back to the login page with a reason.
Auth\LoginNotice::put($message, $tone)— kept in the session;take()pulls it once.loginNoticefor a guest, taken by whichever request builds the bootstrap — the redirected page (inline) or the bootstrap call (xhr). A flash would not survivexhr: the page request ages it.LoginForm: a kitUidAlertabove the form with the notice's tone; hidden once the form shows its own error.integration.md), CHANGELOG under Unreleased,public/rebuilt.Tests: bootstrap carries the notice once, unknown tone falls back to
danger,LoginFormrenders it. Full pest (1247) and vitest (973) green locally.🤖 Generated with Claude Code