Repository navigation
fix(auth): a sign-out stays signed out when a running request saves the session back - #76
Merged
Merged
Conversation
…he session back A request in flight with the session at the sign-out saved it back under the old id and returned the old cookie: the next page load was signed in again (seen on the stand once the sign-out at the provider reloads the page). The sign-out now remembers the ended id in the cache for the session lifetime; AdminAuth (before the public actions) and the BootstrapBuilder (the shell) sign such a request out and give it a fresh session. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the printable stand with RP-initiated logout (1.51.0): the sign-out at Keycloak came back to
/admin/loginsigned in.Trace:
manifest/menu/statuswere in flight with the session whenauth/logoutinvalidated it; they finished afterwards, Laravel saved the session back under the old id and returned the old cookie. Latent before 1.51 (the SPA stayed on its login page, the next F5 was signed in again).Auth\EndedSessions: the sign-out remembers the ended session id (sha256, cache, session lifetime); a request carrying it is signed out and gets a fresh session.AdminAuthbefore the public-action exclusion (bootstrap) and inBootstrapBuilder(the shell's inline bootstrap does not pass AdminAuth) — no host config change needed.🤖 Generated with Claude Code