Adding unit test#32
Open
pmeloni92 wants to merge 1 commit into
Open
Conversation
dsoumis
reviewed
Jul 23, 2025
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately yes, sometimes mockito need this for inline mocking and I need inline mocking for mocking your RestResponse class that is a record class. I cannot think a better way to do it for now.
dsoumis
reviewed
Jul 23, 2025
| import java.util.Map; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
| import static org.mockito.Mockito.*; |
Owner
There was a problem hiding this comment.
We should explicitly define which packages are being imported and avoid "*".
Collaborator
Author
There was a problem hiding this comment.
Yeah, here you're right. I forgot to edit it before PR. Thanks for noticing it, I will do it now.
dsoumis
reviewed
Jul 23, 2025
Collaborator
Author
There was a problem hiding this comment.
Same for the bytebuddy on pom
…ed dependency on pom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit are still dirty but just to give you an overview of what I've done. 1 test still not working but I-m figuring out