test(flow): cover shared rack firmware inputs - #6202
Draft
kunzhao-nv wants to merge 1 commit into
Draft
kunzhao-nv wants to merge 1 commit into
kunzhao-nv wants to merge 1 commit into
Conversation
Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack firmware callers can pass one shared SOT instead of repeating it for each tray type. This PR documents that existing behavior, adds Flow parent/child workflow coverage for shared and per-type inputs, and regenerates the SDK comments and API reference. Request fields and runtime behavior are unchanged.
For
PATCH /v2/org/{org}/nico/rack/{id}/firmware, these requests are equivalent when the same SOT applies to all selected tray types. SOT contents below are abbreviated for illustration.Before: repeat the same SOT in a per-type mapping.
{ "siteId": "550e8400-e29b-41d4-a716-446655440000", "version": "{\"compute\":{\"Id\":\"fw-default\"},\"nvswitch\":{\"Id\":\"fw-default\"},\"powershelf\":{\"Id\":\"fw-default\"}}" }After: use the shared form clarified by this PR. This form already works on
main; it does not require a new flag.{ "siteId": "550e8400-e29b-41d4-a716-446655440000", "version": "{\"Id\":\"fw-default\"}" }Flow passes the shared string unchanged to each selected tray type. A top-level
compute,nvswitch, orpowershelfkey selects the per-type form. A missing key in that form passes an empty input to the backend; it does not guarantee a skipped update.Related issues
None.
Type of Change
Breaking Changes
Testing