Skip to content

test(flow): cover shared rack firmware inputs - #6202

Draft
kunzhao-nv wants to merge 1 commit into
dsx-ai-factory:mainfrom
kunzhao-nv:test/rack-shared-sot
Draft

kunzhao-nv wants to merge 1 commit into
dsx-ai-factory:mainfrom
kunzhao-nv:test/rack-shared-sot

Conversation

@kunzhao-nv

@kunzhao-nv kunzhao-nv commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Rack firmware callers can pass one shared SOT instead of repeating it for each tray type. This PR documents that existing behavior, adds Flow parent/child workflow coverage for shared and per-type inputs, and regenerates the SDK comments and API reference. Request fields and runtime behavior are unchanged.

For PATCH /v2/org/{org}/nico/rack/{id}/firmware, these requests are equivalent when the same SOT applies to all selected tray types. SOT contents below are abbreviated for illustration.

Before: repeat the same SOT in a per-type mapping.

{
  "siteId": "550e8400-e29b-41d4-a716-446655440000",
  "version": "{\"compute\":{\"Id\":\"fw-default\"},\"nvswitch\":{\"Id\":\"fw-default\"},\"powershelf\":{\"Id\":\"fw-default\"}}"
}

After: use the shared form clarified by this PR. This form already works on main; it does not require a new flag.

{
  "siteId": "550e8400-e29b-41d4-a716-446655440000",
  "version": "{\"Id\":\"fw-default\"}"
}

Flow passes the shared string unchanged to each selected tray type. A top-level compute, nvswitch, or powershelf key selects the per-type form. A missing key in that form passes an empty input to the backend; it does not guarantee a skipped update.

Related issues

None.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant