feat: prefer NVIDIA DPU reset for force restart - #139
Draft
zanezhuNVIDIA wants to merge 1 commit into
Draft
zanezhuNVIDIA wants to merge 1 commit into
zanezhuNVIDIA wants to merge 1 commit into
Conversation
Signed-off-by: Zane Zhu <170476994+zanezhuNVIDIA@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (16)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe change adds NVIDIA OpenBMC chassis reset models and uses advertised chassis targets for DPU ChangesNVIDIA DPU reset flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Force restart now prefers the advertised NVIDIA DPU reset action and falls back to the standard Redfish reset when unavailable or stale. The covered fallback paths leave no identified merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant Client
participant ComputerSystem
participant Chassis
participant NvidiaReset
Client->>ComputerSystem: Request ForceRestart
Client->>Chassis: Find matching chassis
Chassis-->>Client: Return OEM reset target
Client->>NvidiaReset: POST ForceDpuReset
NvidiaReset-->>Client: Return success or not-found
Client->>ComputerSystem: Use standard reset when unsupported
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 4 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the "/redfish/v1/Chassis/BlueField_0/Actions/Oem/NvidiaChassis.Reset" endpoint is the official way for BF4 to do the reset.
The standard redfish ForceRestart method may not work with BF4 DPU.
To handle this situation, the nv-redfish would try to use "/redfish/v1/Chassis/BlueField_0/Actions/Oem/NvidiaChassis.Reset" endpoint first to reset the BF4 DPU if the endpoint exists. If the endpoint does not exist, the nv-redfish would be fallback to standard ForceRestart method.
Summary by CodeRabbit
New Features
Tests