Skip to content

Ray kartas: instance extraction fails when worker groups are absent or empty #356

Description

@AviadHayumi

worker groups are optional in RayJob , RayCluster and RayService , but the worker component in their kartas iterates workerGroupSpecs[] unconditionally. two legal manifests break instance extraction:

  1. no workerGroupSpecs at all ( head only RayJob ) - every worker path fails with JQ execution error ... cannot iterate over: null and the whole extraction fails
  2. workerGroupSpecs: [] - iteration is fine , but replicasPath ends with // 1 , and in jq an empty stream // 1 still yields 1. so we get one replicas result for zero instance ids and the zip fails with instance ids count (0) does not match results count (1)

expected: a worker component with no worker groups extracts zero instances , not an error

ray kartas worker groups bug

to reproduce: load docs/catalog/ray-io-rayjob-v1.yaml , build a component factory over a RayJob that only has headGroupSpec , and call GetExtractedInstances on the worker component

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Fields

Priority

None yet

Effort

None yet

Target date

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions