Fixed error with hyperbolic trajectories and with testing function. - #48
Open
ethadhani wants to merge 3 commits into
Open
Fixed error with hyperbolic trajectories and with testing function.#48ethadhani wants to merge 3 commits into
ethadhani wants to merge 3 commits into
Conversation
|
Review these changes at https://app.gitnotebooks.com/dtamayo/spock/pull/48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional checks for hyperbolic trajectories when calculating period ratios and changed return junk period ratio (in the case of no small integer period ratios) to be correctly ordered.
Additionally fixed testing file for feature classifier. One test independently sets up a Trio object and calls get_tseries, both meant to be internal functions. However, the starting features where never initiated resulting in un initiated values being used for calculations.