Updated to work with new Elementor settings method + Readme#2
Open
bcpurleigh wants to merge 2 commits intodtbaker:masterfrom
Open
Updated to work with new Elementor settings method + Readme#2bcpurleigh wants to merge 2 commits intodtbaker:masterfrom
bcpurleigh wants to merge 2 commits intodtbaker:masterfrom
Conversation
# custom-elementor-element This commit allows you to use the code given to immediately install and make use of the boilerplate plugin. Two things have been updated from the current code: 1. Added functionality to support fetching the `my-widget.php` file from the plugin directory, instead of relying on the theme folder having the `my-widget.php` file located in `plugins/elementor/my-widget.php`. 2. Updates the function of getting the values of the input fields, making use of the `$this->get_settings();` method. This is then applied to the `$custom_text` and `$post_count` statements to evaluate correctly. 3. Added in comments for the use of Font Awesome iconset [linking to the Cheat Sheet](http://fontawesome.io/cheatsheet/).
cjmetacrawler
approved these changes
Jan 10, 2019
|
For some reason activating this plugin makes the Elementor Pro fields disappear. Any idea why that would be? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom-elementor-element
This commit allows you to use the code given to immediately install and
make use of the boilerplate plugin. These are the fixes to my previous issue report #1.
Four things have been updated from the current code:
Added functionality to support fetching the
my-widget.phpfilefrom the plugin directory, instead of relying on the theme folder
having the
my-widget.phpfile located inplugins/elementor/my-widget.php.Updates the function of getting the values of the input fields,
making use of the
$this->get_settings();method. This is then appliedto the
$custom_textand$post_countstatements to evaluatecorrectly.
Added in comments for the use of Font Awesome iconset linking to
the Cheat Sheet.
Added a Readme