Expose Field<Type>::get_attrs,get_type#36
Open
TennyZhuang wants to merge 2 commits intodtolnay:masterfrom
Open
Expose Field<Type>::get_attrs,get_type#36TennyZhuang wants to merge 2 commits intodtolnay:masterfrom
Field<Type>::get_attrs,get_type#36TennyZhuang wants to merge 2 commits intodtolnay:masterfrom
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Field<Type>::get_attrsField<Type>::get_attrs,get_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't find any reason to make the
get_attrsmethod only available onField<Value>but notField<Type>.It's very useful when we try to derive a method without self receiver, e.g.:
It is very likely that it was simply forgotten by #22.
@eupn Can you give some suggestions? Thanks!