Conversation
error[E0599]: no associated item named `MAX` found for type `isize` in the current scope
--> src/identifier.rs:106:37
|
106 | debug_assert!(len <= isize::MAX as usize);
| ^^^ associated item not found in `isize`
|
help: you are looking for the module in `std`, not the primitive type
|
106 | debug_assert!(len <= std::isize::MAX as usize);
| ^^^^^^^^^^^^^^^
error[E0599]: no associated item named `MAX` found for type `usize` in the current scope
--> src/identifier.rs:132:44
|
132 | let max_alloc = usize::MAX / 2 - align;
| ^^^ associated item not found in `usize`
|
help: you are looking for the module in `std`, not the primitive type
|
132 | let max_alloc = std::usize::MAX / 2 - align;
| ^^^^^^^^^^^^^^^
takumi-earth
pushed a commit
to earthlings-dev/semver
that referenced
this pull request
Jan 27, 2026
Check for isize overflow before Layout construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#101899. rust-lang/rust#95295, which looks like it is going to be un-reverted, makes the following change to the error condition of
Layout::from_size_alignand thus the safety requirement ofLayout::from_size_align_unchecked: