Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #55. Taking into account the new receive clause ordering behavior, our message handlers ~all operate on disjoint process+message types, where the exceptions are specialized matches which then call-next-method into more generalized matches. This means that the clause ordering expressed in define-message-dispatch is basically unused, and so we could simplify syntax by eliminating it.
This PR moves handler dispatch fully into CLOS, moves guard clauses onto the message handlers, and removes define-message-dispatch.
Companion PRs for the solver libraries to follow.