Skip to content

Fix admin, fee, and pause proposal issues - #335

Merged
dultimateade merged 1 commit into
dultimateade:mainfrom
truetrustfunds-spec:fix/issues-218-217-214-212
Oct 24, 2026
Merged

dultimateade merged 1 commit into
dultimateade:mainfrom
truetrustfunds-spec:fix/issues-218-217-214-212

Conversation

@truetrustfunds-spec

@truetrustfunds-spec truetrustfunds-spec commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Resolve the admin lifecycle, fee status, cooldown ownership, and pause approval issues.

  • Restore the full Markets contract implementation and enforce a 20-address secondary admin cap with admin removal.
  • Use a map for pause proposal approvals to avoid linear membership scans.
  • Keep withdrawal status unchanged when fee collection is below threshold.
  • Borrow Env in internal cooldown helpers while preserving Soroban entrypoint signatures.

Note: pause proposal approval storage changes from Vec<Address> to Map<Address, bool>; deployed pending proposals may require migration.

Closes #216
Closes #217
Closes #214
Closes #212

@dultimateade
dultimateade merged commit 6dfc15a into dultimateade:main Oct 24, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment