336 update prepared statement - #337
Merged
Merged
Conversation
- Add per-SQL prepared statement cache with logical close - Introduce `withConn` and prepared context overloads; add `clearStmtCache`/`flushStmt` - Extend prepared-statement tests and warm benchmarks; update Makefile compose start
- Add per-SQL prepared statement cache and `SqlitePreparedContext` - Make `close()` a logical close; introduce `flushStmt` and `clearStmtCache` - Add `withConn` and `ctx` overloads for prepared `first/get/exec` APIs - Update warm benchmark path and expand SQLite prepared-statement tests
Add prepared statement types, statement cache lifecycle, context-aware execution, and update SurrealDB query builder docs with accompanying tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prepared statement support across RDB drivers (incl. SurrealDB v3)
Summary
This PR introduces a unified prepared statement API across SQLite/PostgreSQL/MySQL/MariaDB, including per-pool caching and connection-scoped execution via
withConn/*PreparedContext. It also adds SurrealDB v3 “prepared statement” support by emulating server-side prepare through client-side template reuse:?placeholders are normalized into SurrealQL parameters and bound values are emitted asLETstatements, executed in a single/sqlrequest for safe reuse.Additionally, it improves pool waiter behavior to ensure concurrent requests correctly complete under tight pool limits, and it updates docs, examples/benchmarks, and test coverage accordingly.
Key changes
prepare,get,first,exec,close, plus cache controlsflushStmt/clearStmtCachewithConnsupport via*PreparedContext, including validation of connection ownership/indexLET+/sqlmulti-statement template expansiontest_pool_waitcoverageTest plan