Skip to content

Update Codex adapter invocation - #64

Merged
duncankmckinnon merged 3 commits into
mainfrom
agent/update-codex-adapter
Aug 5, 2026
Merged

Update Codex adapter invocation#64
duncankmckinnon merged 3 commits into
mainfrom
agent/update-codex-adapter

Conversation

@duncankmckinnon

@duncankmckinnon duncankmckinnon commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the deprecated codex exec --full-auto invocation with --dangerously-bypass-approvals-and-sandbox
  • allow dispatched Codex task and merger agents to stage and commit inside isolated Git worktrees without interactive approval
  • parse the current Codex JSONL item.completed / agent_message event shape
  • retain support for the legacy assistant-message event shape
  • document the unrestricted local-access security tradeoff

Why

Workbench directives require implementor and fixer agents to commit their changes, while merger agents must stage conflict resolutions. Codex's workspace-write sandbox protects .git and resolved worktree Git metadata as read-only, so sandboxed agents cannot reliably complete those steps. The adapter therefore uses Codex's explicit unattended full-access mode.

Impact

Workbench can invoke current Codex CLI versions, reliably extract their final response, and let dispatched agents complete Git operations required by the existing pipeline. Because approvals and sandboxing are bypassed, this adapter should only be used for trusted repositories in appropriately isolated environments.

Validation

  • black --check workbench/adapters.py tests/test_adapters.py
  • isort --check-only workbench/adapters.py tests/test_adapters.py
  • full test suite: 1,185 passed

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@duncankmckinnon
duncankmckinnon marked this pull request as ready for review August 5, 2026 16:54
@duncankmckinnon
duncankmckinnon merged commit b8ea867 into main Aug 5, 2026
5 checks passed
@duncankmckinnon
duncankmckinnon deleted the agent/update-codex-adapter branch August 5, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants