feat(usrp): Optimize USRP TX & RX#236
Open
bpodrygajlo wants to merge 1 commit into
Open
Conversation
Collaborator
|
CI Build: #489 | Not performing CI due to the absence of one of the following mandatory labels:
|
sgarg00
added
BUILD-ONLY
Collaborator
|
CI Build: #500 | Failed on the following stages: |
Collaborator
|
CI Build: #525 | Failed on the following stages: |
bpodrygajlo
force-pushed
the
usrp-txrx-opt
branch
from
4b37128 to
9443a91
Compare
Collaborator
|
CI Build: #541 | Failed on the following stages: |
Contributor
Collaborator
|
CI Build: #582 | Failed on the following stages: |
bpodrygajlo
force-pushed
the
usrp-txrx-opt
branch
from
9443a91 to
5865d0b
Compare
Utilize USRP zero-copy interfaces by registering custom converters. The usage of templates in the converters ensures no impact on conversion performance. Also added a testsuite for the converters. Closes duranta-project#108 Assisted-by: Gemini:3.5-Flash Signed-off-by: Bartosz Podrygajlo <bartosz.podrygajlo@openairinterface.org>
bpodrygajlo
force-pushed
the
usrp-txrx-opt
branch
from
5865d0b to
536b81a
Compare
rorsc
reviewed
Jul 8, 2026
| case 2: | ||
| uhd::convert::register_converter( | ||
| rx_id, | ||
| []() { return uhd::convert::converter::sptr(new sc16_oai_rx_converter<2, swap_be, false>()); }, |
Member
There was a problem hiding this comment.
so the rxshift is maintained. assuming we get rid of them (something to take into account for #187, possibly), we would simply drop the rxshift switch?
I did not see the cmoment from there in here, could you please add it back? It's from Laurent, basically saying that we are shifting when it's not really clear why, since the DFT should use the full scale (I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize USRP zero-copy interfaces by registering custom converters. The usage of templates in the converters ensures no impact on conversion performance. Also added a testsuite for the converters.
Closes #108
Assisted-by: Gemini:3.5-Flash