GNB_APP: dedicated Aerial config section for physical antenna counts#267
Open
gabri94 wants to merge 1 commit into
Open
GNB_APP: dedicated Aerial config section for physical antenna counts#267gabri94 wants to merge 1 commit into
gabri94 wants to merge 1 commit into
Conversation
Add an optional "Aerial" configuration section to set the physical
antenna counts advertised to the Aerial L1 in CONFIG.request:
Aerial = {
num_tx_ant = 4;
num_rx_ant = 4;
};
Until now numRxAnt was derived from pusch_AntennaPorts, coupling the
physical array size to the logical UL ports: a 4x4 radio configured
for 2-layer UL advertised numRxAnt=2, so cuBB dimensioned its PUSCH
MMSE/IRC equalizer for 2 RX antennas and lost the array gain of the
other two. The new parameters decouple physical antennas
(numTxAnt/numRxAnt) from logical ports (numTxPort/numRxPort).
Defaults (0) preserve the previous derivation.
With mMIMO enabled cuBB dimensions PUSCH from the vendor numRxPort
TLV (numRxAnt only sizes SRS) and falls back to a compile-time
constant of 16 ports when the TLV is absent; therefore also send the
logical port TLVs in the beamforming branch, and make the previously
hardcoded 64 physical antennas configurable through the same section.
Assisted-by: Claude Code:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional "Aerial" configuration section to set the physical antenna counts advertised to the Aerial L1 in CONFIG.request:
Aerial = {
num_tx_ant = 4;
num_rx_ant = 4;
};
Until now numRxAnt was derived from pusch_AntennaPorts, coupling the physical array size to the logical UL ports: a 4x4 radio configured for 2-layer UL advertised numRxAnt=2, so cuBB dimensioned its PUSCH MMSE/IRC equalizer for 2 RX antennas and lost the array gain of the other two. The new parameters decouple physical antennas (numTxAnt/numRxAnt) from logical ports (numTxPort/numRxPort). Defaults (0) preserve the previous derivation.
With mMIMO enabled cuBB dimensions PUSCH from the vendor numRxPort TLV (numRxAnt only sizes SRS) and falls back to a compile-time constant of 16 ports when the TLV is absent; therefore also send the logical port TLVs in the beamforming branch, and make the previously hardcoded 64 physical antennas configurable through the same section.
Assisted-by: Claude Code:claude-fable-5