fix(NR_MAC): fix BWP mismatches during F1/N2 handover with dedicated BWP#276
Open
safwan2mo wants to merge 1 commit into
Open
fix(NR_MAC): fix BWP mismatches during F1/N2 handover with dedicated BWP#276safwan2mo wants to merge 1 commit into
safwan2mo wants to merge 1 commit into
Conversation
gNB side: - Set UE->local_bwp_id in create_new_UE() SA path from radio_config, fixing a NULL dereference in configure_UE_BWP() when first_active_bwp != 0 and initialDownlinkBWP is absent from the serving cell dedicated config - Guard bwpd/ubwpd dereferences in configure_UE_BWP() against NULL for configurations where initialDownlinkBWP/initialUplinkBWP are not present - Save and restore UE->local_bwp_id across the RA BWP0 fallback call in configure_UE_BWP() so the post-CFRA scheduling call resolves the correct configured BWP rather than the temporary RA BWP UE side: - Save active BWP IDs before the PRACH BWP switch in init_RA() and restore them after CFRA success in nr_ra_succeeded(), so the UE resumes PDCCH monitoring and SR transmission on the configured BWP instead of staying on the BWP0 used for PRACH
rorsc
added
the
nrUE
safwan2mo
changed the title
rorsc
added
5G-NR
Collaborator
|
CI Build: #720 | Failed on the following stages: |
Collaborator
What about COTS UE? Did you test it? |
Contributor
Author
No, trying to find a way to test this with COTS UE as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
N2-based handover fails when one or both gNBs are configured with a dedicated BWP (
first_active_bwp = 1). Three distinct issues are addressed:gNB (target):
UE->local_bwp_idwas not initialized in the SA path ofcreate_new_UE(), soconfigure_UE_BWP()always resolved to BWP0 and dereferenced a NULLinitialDownlinkBWP(absent whenfirst_active_bwp != 0).local_bwp_id, causing the post-CFRA scheduling call to resolve the wrong BWP.bwpd/ubwpddereferences are additionally guarded against NULL.UE:
rach_ConfigCommon), the UE was not restoring the configured BWP on CFRA success. The UE stayed on BWP0 while the gNB resumed scheduling on the configured BWP, causing mutual deafness and repeated re-establishment.Note for reviewers:
local_bwp_idsave/restore around the RA fallback should be reviewed for full spec compliance. The current changes are confirmed working for the dedicated BWP scenario in RFSIM.