Skip to content

Version 1.1.1#5

Merged
dusrdev merged 3 commits into
mainfrom
publish-hotfix
Mar 22, 2026
Merged

Version 1.1.1#5
dusrdev merged 3 commits into
mainfrom
publish-hotfix

Conversation

@dusrdev

@dusrdev dusrdev commented Mar 22, 2026

Copy link
Copy Markdown
Owner

No description provided.

@dusrdev dusrdev merged commit 5eb0c77 into main Mar 22, 2026
3 checks passed
@dusrdev dusrdev deleted the publish-hotfix branch March 22, 2026 17:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97a9bc2245

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +444 to +446
- name: Publish GitHub release to WinGet
if: ${{ env.WINGET_TOKEN != '' }}
uses: vedantmgoyal9/winget-releaser@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fail the WinGet job when the PAT secret is missing

If WINGET_PACKAGE_IDENTIFIER is configured but WINGET_TOKEN is absent (for example after a secret rotation or in another release environment), this step is simply skipped and the job still finishes green because it has no other work. That leaves the GitHub release published but WinGet stale with no signal to the releaser that the install channel was not updated.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial winget release needs to be manual. As such the WINGET_PACKAGE_IDENTIFIER was removed on purpose to skip this part.
After the manual PR to winget packages was made, the variable was added to the repo to be used in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant