Version 1.1.1#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97a9bc2245
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Publish GitHub release to WinGet | ||
| if: ${{ env.WINGET_TOKEN != '' }} | ||
| uses: vedantmgoyal9/winget-releaser@v2 |
There was a problem hiding this comment.
Fail the WinGet job when the PAT secret is missing
If WINGET_PACKAGE_IDENTIFIER is configured but WINGET_TOKEN is absent (for example after a secret rotation or in another release environment), this step is simply skipped and the job still finishes green because it has no other work. That leaves the GitHub release published but WinGet stale with no signal to the releaser that the install channel was not updated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Initial winget release needs to be manual. As such the WINGET_PACKAGE_IDENTIFIER was removed on purpose to skip this part.
After the manual PR to winget packages was made, the variable was added to the repo to be used in the future.
No description provided.