Conversation
Return the watch response before awaiting backpressured backlog writes and run replay under ctx.waitUntil. Clean up cancelled streams and cover replay, reconnect cursors, live events, and cancellation with Workers tests. Closes #360 Co-Authored-By: Duyet Le <me@duyet.net> Co-Authored-By: duyetbot <bot@duyet.net>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideThe PR fixes SSE watch requests hanging on backpressured backlog replay by returning the response before replay writes, running replay via Durable Object waitUntil, and reliably cleaning up on cancellation or failure. Real Workers tests cover backlog replay, reconnect cursors, live delivery, and cancellation. Sequence diagram for non-blocking SSE backlog replaysequenceDiagram
participant Client
participant DurableObject as DurableObject
participant Stream as TransformStream
participant WaitUntil as ctx.waitUntil
Client->>DurableObject: watch(projectId, after, signal)
DurableObject->>Stream: create stream and writer
DurableObject->>WaitUntil: writeBacklog(writer, projectId, after)
DurableObject-->>Client: Response(stream.readable)
WaitUntil->>Stream: writer.write(backlog event)
Stream-->>Client: replayed SSE event
DurableObject->>Stream: writer.write(live event)
Stream-->>Client: live SSE event
Sequence diagram for SSE cancellation cleanupsequenceDiagram
participant Client
participant DurableObject as DurableObject
participant Stream as TransformStream
participant Writer
Client->>DurableObject: watch(projectId, after, signal)
DurableObject->>Stream: create stream and writer
DurableObject-->>Client: Response(stream.readable)
DurableObject->>Writer: writeBacklog(writer, projectId, after)
Client->>DurableObject: abort signal
DurableObject->>Stream: controller.error(signal.reason)
DurableObject->>Writer: cleanup writer and heartbeat
Writer-->>DurableObject: release backpressured write
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #360
Verification
Scope
Co-Authored-By: Duyet Le me@duyet.net
Co-Authored-By: duyetbot bot@duyet.net
🤖 Generated with Claude Code
Summary by Sourcery
Unblock SSE watch response delivery while safely handling background backlog replay and stream cancellation.
Bug Fixes:
Tests: