Skip to content

Modernize tooling, replace Jenkins CI, and harden wallet flows - #5

Merged
dvkam merged 11 commits into
mainfrom
chore/modernize-toolchain
Oct 17, 2026
Merged

dvkam merged 11 commits into
mainfrom
chore/modernize-toolchain

Conversation

@dvkam

@dvkam dvkam commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Replace the Jenkins pipeline with a read-only GitHub Actions build on pushes and pull requests, and modernize the template's development tools. The project now uses pnpm 12 with workspace deduplication, TypeScript 7, Vite 8, React 19.3, type-aware oxlint, oxfmt, and shared strict compiler settings.

The wallet flow uses React form actions with pending/error states and exact mutez validation. It rejects unsuccessful transaction execution after inclusion, observes external account changes, and checks the displayed sender before submission. Responsive controls, keyboard focus, and persistent status announcements improve accessibility.

Validation:

  • Clean frozen pnpm installation and full production build pass.
  • Type-aware lint, formatting, both strict TypeScript configurations, and 28 tests pass.
  • Two review rounds with pstack, Matt Pocock, and Emil skills completed; actionable findings fixed in separate commits.
  • Production startup, keyboard focus, and a 390px viewport checked in browser. Real wallet pairing and transfers were not attempted.

Known limitations: the existing wallet SDK produces browser-externalization warnings and a large entry bundle (about 978 KB gzip), plus a harmless startup subscription warning before the React effect registers. Hosted CI is being checked on this PR.

@dvkam
dvkam merged commit a5b7d94 into main Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant