Feature/cb2 10594 - add upsert functionality for (tech-record's) ADR-Details attributes#79
Open
Feature/cb2 10594 - add upsert functionality for (tech-record's) ADR-Details attributes#79
Conversation
added 19 commits
January 26, 2024 13:56
… adding in-line comments
…ent RDS engine upgarde for NOP
meys-bjss
requested review from
DanielFry-bjss,
Nat-McCabe-BJSS,
me-matt,
reisedawson,
shivangidas and
simontindallbjss
meys-bjss
changed the title
… able to push changes into repo
… able to push changes into repo
…pdate-store into feature/CB2-10594
… able to push changes into repo
* rectifying data type mismatches, add un-defined Enums and attributes, adding in-line comments * add AdrCertificateDetails interface and parsing function * adding guidanceNotes Enum * adding m145 attribute as per documentation change * feat: adr details added, test resource for technoical record added, unit test added * style: rearrange enums * fix: replace ! with ? for optional attributes * fix: memosApplyEnum value updated * fix: 2 new attributes added to adrDetails, as per documentation * feat: tab le definition * fix: enum updated * feat: adr tables added to the tech record list of tables * feat: new function added for partial upsert based on condition attribute * feat: some adr table detail updated * feat: upsert fun ctionality added for adr-details attributes in tech record * feat: adr parts added to tech record integration test * feat: docker's mysql image updated to version 8 - consistent with recent RDS engine upgarde for NOP * feat: adr attribute values updated * feat: test updated as adr attribute values updated in json file * fix: changes reverted back to original * fix: changes reverted back to original * fix: changes reverted back to original * feat: cleaning and bringing in adr pass certificate * feat: cleaning and bringing in adr pass certificate * feat: cleaning and bringing in adr pass certificate * fix: removed async keyword to avoid error when running the test * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: updating adr pass certificate function * fix: updating adr pass certificate field name * fix: updating adr pass certificate var name * feat: adding integration tests for additional test scenarios * feat: adding adr pass certificate attribute * feat: adding adr pass certificate attribute test to unit test * fix: syntax fixed --------- Co-authored-by: Meys Torkaman <meys.torkaman@MacBook-Pro.local> Co-authored-by: meys-bjss <140601718+meys-bjss@users.noreply.github.com>
* rectifying data type mismatches, add un-defined Enums and attributes, adding in-line comments * add AdrCertificateDetails interface and parsing function * adding guidanceNotes Enum * adding m145 attribute as per documentation change * feat: adr details added, test resource for technoical record added, unit test added * style: rearrange enums * fix: replace ! with ? for optional attributes * fix: memosApplyEnum value updated * fix: 2 new attributes added to adrDetails, as per documentation * feat: tab le definition * fix: enum updated * feat: adr tables added to the tech record list of tables * feat: new function added for partial upsert based on condition attribute * feat: some adr table detail updated * feat: upsert fun ctionality added for adr-details attributes in tech record * feat: adr parts added to tech record integration test * feat: docker's mysql image updated to version 8 - consistent with recent RDS engine upgarde for NOP * feat: adr attribute values updated * feat: test updated as adr attribute values updated in json file * fix: changes reverted back to original * fix: changes reverted back to original * fix: changes reverted back to original * feat: cleaning and bringing in adr pass certificate * feat: cleaning and bringing in adr pass certificate * feat: cleaning and bringing in adr pass certificate * fix: removed async keyword to avoid error when running the test * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo * fix: updating adr pass certificate function * fix: updating adr pass certificate field name * fix: updating adr pass certificate var name * feat: adding integration tests for additional test scenarios * feat: adding adr pass certificate attribute * feat: adding adr pass certificate attribute test to unit test * fix: syntax fixed * fix: updating for tank statement attributes, add conditions for missing attributes * fix: updating for tank statement attributes * fix: updating for tank statement attributes * fix: updating for tank statement attributes * fix: updating for tank statement attributes --------- Co-authored-by: Meys Torkaman <meys.torkaman@MacBook-Pro.local> Co-authored-by: meys-bjss <140601718+meys-bjss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the update-store's upsert functionality for ADR attributes so that it stores the ADR Details attributes into NOP tables.
Related issue:
CB2-10594
CB2-10593
CB2-10592
Useful links:
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/382011842/ADR+Section
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/494174610/SPIKE+Validate+existing+update-store+functionality+for+ADR
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/493781660/CB2-10450+-+SPIKE+Compare+NOP+ADR+data+model+to+Dynamo
Before submitting (or marking as "ready for review")