This repository was archived by the owner on Aug 11, 2026. It is now read-only.
chore: standardize k8s/ to base/+overlays/ convention (homelab#141) - #8
Merged
Conversation
k8s/ previously had no kustomization.yaml -- ArgoCD applied the flat files directly as a raw manifest source. Introduces kustomize for the first time: k8s/base/ holds the manifests (unchanged), k8s/overlays/ is a thin wrapper (resources: [../base]). Verified additive/structural only: rendered `kubectl kustomize k8s/overlays/` produces the same 7 objects with identical content as the original flat files. Fork-pressure note: this is a fork of AUTOMATIC1111's stable-diffusion- webui with a custom Dockerfile/deploy layer. This PR only touches the deploy manifests (k8s/), not the forked application code, so it doesn't add to future upstream-merge friction. Depends on a matching path update in dvystrcil/argocd-projects (sd-webui-rcom Application, spec.sources[0].path 'k8s' -> 'k8s/overlays') -- merge both PRs together. automated.selfHeal is enabled, so whichever merges first will show a brief non-destructive transient sync error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of homelab#141.
k8s/previously had no kustomization.yaml at all — ArgoCD applied the flat files directly as a raw manifest source (spec.sources[0].path: 'k8s'). This PR introduces kustomize for the first time:k8s/base/holds the manifests unchanged,k8s/overlays/is a thin wrapper (resources: [../base]).Verified additive/structural only:
kubectl kustomize k8s/overlays/renders the same 7 objects with identical content as the original flat files.Fork-pressure note: this repo is a fork of AUTOMATIC1111's stable-diffusion-webui with a custom Dockerfile/deploy layer. This PR only touches the deploy manifests (
k8s/), not forked application code.Merge together with the companion
argocd-projectsPR (sd-webui-rcomApplication,spec.sources[0].pathk8s→k8s/overlays; the app's second source,gateway-services, is untouched).automated.selfHealis enabled, so whichever merges first will show a brief, non-destructive transient sync error.Test plan
kubectl kustomize k8s/overlays/structurally identical to pre-migration flat manifests (7/7 objects match)validateCI check (kustomize-validate-action) passessd-webui-rcomArgoCD Application returns toSynced/Healthy