Skip to content

chore(deps): bump criterion from 0.5.1 to 0.8.2 #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps): bump criterion from 0.5.1 to 0.8.2 #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/tui-rs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
# Reconstruct real terminal cells in PTY assertions, including cursor-only spaces.
vt100 = "0.16.2"
pretty_assertions = "1"
criterion = { version = "0.5", features = ["html_reports"] }
criterion = { version = "0.8", features = ["html_reports"] }

Check failure on line 192 in packages/tui-rs/Cargo.toml

View workflow job for this annotation

GitHub Actions / unresolved-review-threads / unresolved-review-threads

unresolved P1 review thread

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace deprecated black_box before bumping Criterion

With Criterion 0.8 selected here, the existing bench files that import criterion::black_box (for example packages/tui-rs/benches/batch_bench.rs:5 and five others) start using a symbol Criterion 0.8 marks deprecated in favor of std::hint::black_box (docs.rs). The CI workflows I checked run cargo clippy --workspace --all-targets --locked -- -D warnings (.github/workflows/ci.yml:29 and .github/workflows/rust.yml:19); Cargo help describes --benches as checking bench targets and --all-targets as checking all targets, so these deprecation warnings become hard errors. Please update the bench imports/calls as part of this dependency bump.

Useful? React with 👍 / 👎.

wat = "1"
# Enables `#[tokio::test(start_paused = true)]` for deterministic timeout tests.
tokio = { workspace = true, features = ["test-util"] }
Expand Down
Loading