Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
wait-timeout = "0.2"
x509-parser = "0.18"
zip = { version = "8", default-features = false, features = ["aes-crypto", "deflate64", "deflate", "lzma", "ppmd", "time", "zstd", "xz"] }
tree-sitter = "0.25"
tree-sitter = "0.26"

Check failure on line 73 in Cargo.toml

View workflow job for this annotation

GitHub Actions / unresolved-review-threads / unresolved-review-threads

unresolved P1 review thread

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Migrate the parser timeout before upgrading tree-sitter

With this dependency bump, the lockfile resolves tree-sitter to 0.26.12, whose Rust Parser API no longer exposes set_timeout_micros; however packages/tui-rs/src/safety/bash_analyzer.rs still calls parser.set_timeout_micros(50_000). In any CI/job that compiles maestro-tui with the updated lockfile, such as the existing cargo clippy --workspace --all-targets --locked lanes, the workspace will fail to build until that call is migrated to ParseOptions/parse_with_options or the dependency stays on 0.25.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move the dependency bump to the mirror source

This changes a source dependency directly in the generated public mirror. The repository guidance says public-facing source changes should originate in evalops/maestro-internal and arrive through the protected mirror workflow, so landing the bump here creates drift that can be overwritten and bypasses the source-of-truth validation path; please make this update in the internal repo and mirror it back.

Useful? React with 👍 / 👎.

tree-sitter-bash = "0.25.1"

# Keep the canonical release profile deliberately optimized for shipped
Expand Down
Loading