Repository navigation
chore: sync public mirror from internal - #1169
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b4252cfae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for directory in current.ancestors() { | ||
| if directory.join("products/maestro").is_dir() { | ||
| return Ok(directory.to_path_buf()); |
There was a problem hiding this comment.
When Studio is run from the documented public repository root, no current-directory or manifest ancestor contains a products/maestro child—the Cargo workspace is the repository root itself—so repo_root() always returns run Studio inside the Mono repository. Consequently every studio new/promote invocation, including --check, is unusable in this repository; root discovery and the monorepo-prefixed adapter paths need a public-layout fallback.
Useful? React with 👍 / 👎.
| } else if captures.iter().any(|capture| capture.semantic.is_some()) { | ||
| CoverageState::AssertedPassed |
There was a problem hiding this comment.
For a replay whose final input resizes to a geometry outside the selected profile, results_for retains only earlier prefixes; those prefixes still have semantic: Some(...) but deliberately contain no expectations. This branch therefore reports AssertedPassed even though the story contract was never evaluated for that profile, producing false-positive coverage. Only semantic results with evaluated expectations should qualify as asserted.
Useful? React with 👍 / 👎.
| } | ||
| let before = fs::read_to_string(®istration).map_err(|error| error.to_string())?; | ||
| let after = registration_with_story(&before, &recipe.id.replace('-', "_"))?; | ||
| let source = recipe.fixture_source_for_adapter(&adapter.id)?; |
There was a problem hiding this comment.
When studio promote --adapter theme-selector ... --check is used, the adapter is authoring-enabled, so planning succeeds and this line generates a menu-recipe module despite that manifest declaring the ThemeSelector template and no Menu story kind. The theme-selector registration macro expects generated modules to expose captures(), while this source exposes register(), so a real promotion can only fail compilation and roll back, and --check misleadingly approves the invalid plan. Validate the adapter template/story kind before promotion.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth44398bc78a6101246b54c93a5c14fdf51b592a05b845d90c5168779978aa9579a9d6b837c0870eab33file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@44398bc78a6101246b54c93a5c14fdf51b592a05
Prior destination base: b845d90
Content SHA-256: f2f670aaf2deaad783ec6d930f42e640de1e7ffb5ddb1b35339b9a2e0db37700
Result: drift_detected; 33 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update Cargo.lock
copy/update packages/tui-rs/examples/onboarding-preview.rs
copy/update packages/tui-rs/examples/support/mod.rs
copy/update packages/tui-rs/examples/support/theme_selector_story.rs
copy/update packages/tui-rs/examples/support/ui_stories.rs
copy/update packages/tui-rs/src/components/theme_selector.rs
copy/update packages/ui-preview-rs/Cargo.toml
copy/update packages/ui-preview-rs/README.md
copy/update packages/ui-preview-rs/src/adapters.rs
copy/update packages/ui-preview-rs/src/authoring.rs
copy/update packages/ui-preview-rs/src/contract.rs
copy/update packages/ui-preview-rs/src/lib.rs
copy/update packages/ui-preview-rs/src/main.rs
copy/update packages/ui-preview-rs/src/menus.rs
copy/update packages/ui-preview-rs/src/registry.rs
copy/update packages/ui-preview-rs/src/review.html
copy/update packages/ui-preview-rs/src/review.rs
copy/update packages/ui-preview-rs/src/schema.rs
copy/update packages/ui-preview-rs/src/stories/mod.rs
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@44398bc78a6101246b54c93a5c14fdf51b592a05, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.