Repository navigation
chore: sync public mirror from internal - #1172
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95b2c63581
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let Some(state) = states.get_mut(&relay_id) else { | ||
| return; |
There was a problem hiding this comment.
Recheck registration before discarding an observation
When an existing relay keeps the hub worker active, a new relay can send Register just after drain_control_messages finishes and then enqueue its first observation before the worker begins or completes the data loop. The worker consumes that observation here while the registration remains queued on the separate control channel, so it silently returns; losing an initial OperationObservation::Admitted or TurnStarted drops the turn ID and experiment assignment and corrupts the resulting telemetry. Handle the pending registration before dropping an unknown relay's message, or serialize registration and observations on one channel.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth6139cda76fc6bd4d07a40c8351468364c090e6197f514fca918d431635a0ba92a825eb4bd0812cac2file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@6139cda76fc6bd4d07a40c8351468364c090e619
Prior destination base: 7f514fc
Content SHA-256: 0a9c99f245ca6f3b5929664ecdaa6dc22347566ee2a0af6f97bd8ac4c482bc64
Result: drift_detected; 2 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update packages/local-host-rs/src/telemetry/relay.rs
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@6139cda76fc6bd4d07a40c8351468364c090e619, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.