Repository navigation
chore: sync public mirror from internal - #1173
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9c2b93f1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if getattr(args, "changed", False): | ||
| tail.extend(changed_review_filter()) |
There was a problem hiding this comment.
Prevent --changed from adding a second scope filter
In a Mono checkout where changed_review_filter() selects --adapter shared-menu, invoking ./dev ui review --changed --story menu-ready appends both adapter and story filters. The downstream parser defines these as mutually exclusive in scripts/dev/ui-workbench.py:730-732, so this otherwise accepted front-door command exits before opening the workbench. Make --changed mutually exclusive with explicit selectors, or let the explicit selector override the inferred filter.
Useful? React with 👍 / 👎.
| [UI contributor workflow](docs/ui-contributor-workflow.md) for adapters, | ||
| compatibility, and pull request evidence. |
There was a problem hiding this comment.
Link to a workflow that exists in the public repository
The newly added contributor link targets docs/ui-contributor-workflow.md, but that file is absent from this commit and a repo-wide search finds only this reference. Public contributors following the new UI setup therefore reach a broken link; add the projected workflow document or point this link at an existing public guide.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth915d91afd3e2038786a2e1cf12dd920ce17a831609d57e69e8649768da349fb38eb9c513df0e5d0120file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@915d91afd3e2038786a2e1cf12dd920ce17a8316
Prior destination base: 09d57e6
Content SHA-256: eeeb25196b828d9c832f1193fd3974f52c00fd422ed308c137262393d8a9b7d4
Result: drift_detected; 20 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update CONTRIBUTING.md
copy/update dev
copy/update packages/tui-rs/examples/onboarding-preview.rs
copy/update packages/tui-rs/examples/support/theme_selector_story.rs
copy/update packages/tui-rs/examples/support/ui_stories.rs
copy/update packages/ui-preview-rs/README.md
copy/update packages/ui-preview-rs/src/adapters.rs
copy/update packages/ui-preview-rs/src/main.rs
copy/update packages/ui-preview-rs/src/registry.rs
copy/update packages/ui-preview-rs/src/review.html
copy/update packages/ui-preview-rs/src/review.rs
copy/update packages/ui-preview-rs/src/web/playback.js
copy/update packages/ui-preview-rs/src/web/tests.mjs
copy/update packages/ui-preview-rs/src/web/workspace.js
copy/update packages/ui-preview-rs/tests/studio_cli.rs
copy/update packages/ui-rs/README.md
copy/update scripts/dev/test-dev-ui.py
copy/update scripts/dev/test-ui-workbench.py
copy/update scripts/dev/ui-workbench.py
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@915d91afd3e2038786a2e1cf12dd920ce17a8316, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.