Repository navigation
chore: sync public mirror from internal - #1225
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9842581d86
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| _ => { | ||
| let _ = tx.send(StreamEvent::ProviderError { | ||
| kind: ProviderStreamErrorKind::TransientProtocol, | ||
| message: "Chat stream returned an unknown finish reason".to_string(), | ||
| }); |
There was a problem hiding this comment.
Handle the valid content_filter finish reason
When OpenAI or Azure OpenAI terminates a chat completion with the documented finish_reason: "content_filter", this wildcard treats the valid terminal response as a transient protocol failure. If no content was emitted, the unified stream layer retries the same filtered request up to its retry limit; otherwise the turn fails after partial output, and usage in the terminal chunk is discarded. Map this reason to an appropriate terminal/non-retryable outcome instead of rejecting it as unknown. Apply the correction in the internal source before mirroring it here.
AGENTS.md reference: AGENTS.md:L7-L9
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth883bd85c592bbfc7ac95992291f8b02e87011ecd6ede82720df7af1028a4791aeb49593e5c9c7bbc2file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@883bd85c592bbfc7ac95992291f8b02e87011ecd
Prior destination base: 6ede827
Content SHA-256: cd333a61496a0fd449c9b897ac7dec59e0302939c30d209e47898db02ae480d9
Result: drift_detected; 2 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update packages/ai-rs/src/openai.rs
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@883bd85c592bbfc7ac95992291f8b02e87011ecd, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.