chore: sync public mirror from internal - #1245
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f61f84031a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let definition = state.definitions.get(&run.automation_id).cloned(); | ||
| let retryable = !result.succeeded | ||
| && definition | ||
| .as_ref() | ||
| .is_some_and(|definition| run.attempt < definition.max_attempts); |
There was a problem hiding this comment.
Stop deleted runs retrying against recreated definitions
If an automation is deleted while a run is active and a new automation with the same ID is created before that run fails, this lookup finds the replacement definition and marks the old run retryable. claim_due then builds the retry from that replacement definition's prompt and model, so a run that belonged to the deleted automation can cause an unexpected execution of the newly created one. Record the claimed definition/version with the run, or make an active run terminal once its original definition has been deleted.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truthd7a05a296e07cd1ffdd6650388e10b87b10a0de7e1f9849efdcf6b633197a16c36855e59e050b6273file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@d7a05a296e07cd1ffdd6650388e10b87b10a0de7
Prior destination base: e1f9849
Content SHA-256: e6e93ea0769f4bd63e5aea305914b79869813d5138b1161347463c2055779d3d
Result: drift_detected; 3 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update packages/runtime-gateway-rs/src/automations.rs
copy/update packages/runtime-gateway-rs/src/extended.rs
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@d7a05a296e07cd1ffdd6650388e10b87b10a0de7, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.