chore: sync public mirror from internal - #1306
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3b0bfffc6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if let Some(result) = prefetch.reads.take_done(index) { | ||
| self.finish(ctx, &calls[index], result).await?; | ||
| running | ||
| .drive(self.finish(ctx, &calls[index], result)) | ||
| .await?; |
There was a problem hiding this comment.
Poll pending prefetched reads before finishing completed siblings
When one prefetched read has already completed but a later sibling is still pending and holds the thread's log-row lock (for example, while emitting tool progress), this branch appends ToolFinished through the new empty running handle before line 1374 moves that sibling into it. The append waits on the lock while the pending prefetch is no longer polled to release it, so Engine::run deadlocks. The removed outer prefetch.reads.drive(self.dispatch(...)) previously kept all prefetched reads progressing during this append; move pending prefetch futures into running before finishing adopted results, or preserve that outer driver.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth4c3e830640c4066c99303b7582fa2bdb74095f0dca90e530cac35a9d63eac51f920d58891a511b2114file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@4c3e830640c4066c99303b7582fa2bdb74095f0d
Prior destination base: ca90e53
Content SHA-256: f684b3dd9cbf2e4f672beaa7d0c536d87035881e1cdb7f5d28afeebe1e49b530
Result: drift_detected; 14 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .repository-projection.json
copy/update packages/dex-host-rs/src/model.rs
copy/update packages/dex-host-rs/src/turn.rs
copy/update packages/dex-host-rs/tests/turn.rs
copy/update vendor/dex-loop/src/engine.rs
copy/update vendor/dex-loop/src/event.rs
copy/update vendor/dex-loop/src/lib.rs
copy/update vendor/dex-loop/src/ports.rs
copy/update vendor/dex-loop/tests/prefetch.rs
copy/update vendor/dex-loop/tests/prefetch_authority.rs
copy/update vendor/dex-loop/tests/scenarios.rs
copy/update vendor/dex-loop/tests/sim/fakes.rs
copy/update vendor/dex-loop/tests/support/mod.rs
copy/update vendor/dex-loop/tests/tool_deadline.rs
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@4c3e830640c4066c99303b7582fa2bdb74095f0d, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.