Skip to content
This repository was archived by the owner on Sep 8, 2026. It is now read-only.

fix(api): box tenant limit rejection responses - #409

Merged
haasonsaas merged 2 commits into
mainfrom
fix/rust-1.98-large-error
Aug 25, 2026
Merged

haasonsaas merged 2 commits into
mainfrom
fix/rust-1.98-large-error

Conversation

@haasonsaas

@haasonsaas haasonsaas commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • box the tenant-limit middleware's error response on its cold rejection path
  • preserve response status, headers, body, counter semantics, and success-path allocation behavior
  • restore the floating Rust 1.98 Clippy gate without suppressing the lint or mixing this prerequisite into fix(api): diagnose empty sterile cell claims #408

Diagnosis

Rust 1.98's clippy::result_large_err now rejects the pre-existing consume(...) -> Result<(), Response> signature in limits.rs. Current main reproduces the failure and no open Sandboxwich PR owns it. The large Axum response is only constructed on database/rate-limit rejection paths, so boxing the error variant is the smallest behavior-preserving fix.

Validation

  • cargo +stable fmt --check
  • cargo +stable clippy --workspace --all-targets -- -D warnings
  • cargo +stable test --workspace
  • cargo +1.95.0 fmt --check
  • cargo +1.95.0 clippy --workspace --all-targets -- -D warnings
  • focused SQLite tenant-limit HTTP contract passed
  • PostgreSQL tenant-limit case was skipped locally because SANDBOXWICH_TEST_POSTGRES_URL is not configured

No deployment or production mutation was performed.


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@haasonsaas
haasonsaas merged commit 776b06f into main Aug 25, 2026
1 check was pending
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants