This repository was archived by the owner on Sep 8, 2026. It is now read-only.
Repository navigation
fix(api): box tenant limit rejection responses - #409
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a03558-2154-7552-8a14-b14c6c9b2d63 Co-authored-by: Jonathan Haas <jhaas@corp.deixic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosis
Rust 1.98's
clippy::result_large_errnow rejects the pre-existingconsume(...) -> Result<(), Response>signature inlimits.rs. Currentmainreproduces the failure and no open Sandboxwich PR owns it. The large Axum response is only constructed on database/rate-limit rejection paths, so boxing the error variant is the smallest behavior-preserving fix.Validation
cargo +stable fmt --checkcargo +stable clippy --workspace --all-targets -- -D warningscargo +stable test --workspacecargo +1.95.0 fmt --checkcargo +1.95.0 clippy --workspace --all-targets -- -D warningsSANDBOXWICH_TEST_POSTGRES_URLis not configuredNo deployment or production mutation was performed.