Skip to content

Fix secondary header menu items stacking vertically#794

Merged
jjroelofs merged 1 commit into6.xfrom
jur/6.x/793-fix-secondary-header-menu-stacking
Mar 31, 2026
Merged

Fix secondary header menu items stacking vertically#794
jjroelofs merged 1 commit into6.xfrom
jur/6.x/793-fix-secondary-header-menu-stacking

Conversation

@jjroelofs
Copy link
Copy Markdown
Collaborator

Linked issues

Solution

Add flex-direction: row to #secondary-header ul.menu to override Bootstrap 5's default flex-direction: column on .navbar-nav. The fix is scoped to the secondary header only because the main navigation already uses Bootstrap's .navbar-expand-lg class which properly manages flex-direction based on viewport.

Checklist

  • I have read the CONTRIBUTING.md document.
  • My commit messages follow the contributing standards and style of this project.
  • My code follows the coding standards and style of this project.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Need to run update.php after code changes
  • Requires a change to end-user documentation.
  • Requires a change to developer documentation.
  • Requires a change to QA tests.
  • Requires a new QA test.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Bootstrap 5's .navbar-nav sets flex-direction: column by default,
which overrides the float: left on list items. Add flex-direction: row
to #secondary-header ul.menu so items display inline.

Fixes #793
@jjroelofs jjroelofs merged commit 715163d into 6.x Mar 31, 2026
2 of 3 checks passed
@jjroelofs jjroelofs deleted the jur/6.x/793-fix-secondary-header-menu-stacking branch March 31, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant