Fix secondary header menu items stacking vertically#795
Merged
Conversation
Bootstrap 5's .navbar-nav sets flex-direction: column by default, which overrides the float: left on list items. Add flex-direction: row to #secondary-header ul.nav so items display inline. Fixes #793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
Add
flex-direction: rowto#secondary-header ul.navto override Bootstrap 5's defaultflex-direction: columnon.navbar-nav. The secondary header's<ul class="nav navbar-nav">is not inside a.navbar-expand-*wrapper, so Bootstrap's column default applies. The fix is scoped to the secondary header only because the main navigation already uses.navbar-expand-lg.Checklist