Add type declarations - Closes #5 #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parse()` expects a string as an argument. We are now using strict_types=1, meaning a TypeError will return before the failing test is executed.
This test is failing and will be addressed under issue: #24
Contributor
|
This all looks fine to me. Do you have a plan for tackling #24? I'm not sure whether it's really big enough to split into a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
Types were already declared in some functions, however they were not being enforced, due to
strict_typesnot being used in those files.This PR addresses that issue by adding
declare(strict_types=1)to the files.Changes
testParseFailureAis failing #24