Fixes to compile on FreeBSD 10.1-RELEASE #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NO MEANS a C++ programmer (perl/java), but a little hacking around got things to compile. I've tested the raw binaries and they at least set up a minimal session with our Juniper gear. Added missing includes for files needing <pthread.h> by adding threads.h to the cpp files that were throwing errors about missing pthread symbols. threads.h has a "pragma once", so that seemed to be the least destructive way to do it. Fixed a small compiler warning about unsigned short (vs int). Left other compiler warnings about unused fields alone (several are acknowledged in the source, so choosing not to mess with them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this project while trying to signal a Juniper router from a FreeBSD box. The latest released packages and git sources wouldn't compile cleanly on the system, but a little hacking got it to run. Figured I'd share in case it helps someone.
I am BY NO MEANS a C++ programmer (perl/java is my thing), so if these fixes are weird/inefficient feel free to reject. They were IMNSHO pretty minor:
Added missing includes for files needing <pthread.h> by adding threads.h to the cpp files that were throwing errors about missing pthread symbols. threads.h has a "pragma once", so that seemed to be the least destructive way to do it.
Fixed a small compiler warning about unsigned short (vs int).
Added to quiet a warning about "namespace std" (stackexchange to the rescue on that; I've no idea what this error was about).
Left other compiler warnings about unused fields alone (several are acknowledged in the source, so choosing not to mess with them).
Source now builds with only the aforementioned warnings, and the binaries run (I've confirmed basic interop with our Juniper gear). Yay!