Merged
Conversation
hainest
requested changes
Dec 10, 2025
Co-authored-by: Tim Haines <thaines.astro@gmail.com>
Co-authored-by: Tim Haines <thaines.astro@gmail.com>
Co-authored-by: Tim Haines <thaines.astro@gmail.com>
Co-authored-by: Tim Haines <thaines.astro@gmail.com>
kupsch
reviewed
Dec 12, 2025
Contributor
kupsch
left a comment
kupsch
left a comment
There was a problem hiding this comment.
Here's some changes to make this clearer
kupsch
approved these changes
Dec 12, 2025
Member
Author
|
@hainest Can you re-review? |
hainest
approved these changes
Dec 16, 2025
Contributor
hainest
left a comment
hainest
left a comment
There was a problem hiding this comment.
LGTM. There are a few more items we could add, but this is much improved. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.