Conversation
|
hey @ibrahimgb thanks for the PR, is there a need or a reason for this change? |
Codecov Report
@@ Coverage Diff @@
## develop #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 173 173
Branches 33 33
=========================================
Hits 173 173 Continue to review full report at Codecov.
|
|
reason for this change: the hole data was crammed in one line. I just organize it to make it easy for future contributions (who want to update the dataset).
|
|
Hi @ibrahimgb the idea was to pull the dataset from the files in https://github.com/Fcmam5/algeria-api which is now super outdated. Or, do you have any suggestions for doing this better? We can keep the prettified version of the dataset and only minified when building the library |
Description
i have reorganized the code layout for the data file I have not edited nor changed the data
Fixes # (issue)
Type of change
reorganized
Please delete options that are not relevant.
Checklist:
npm run update-dataset)npm testpasses on my machinenpm run lintpasses on my machine