Add usage overview for questionnaires #2599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richardebeling
left a comment
richardebeling
left a comment
There was a problem hiding this comment.
lgtm, but I think we shouldn't spend resources to remove the breadcrumb link
Comment on lines
+7
to
+11
| {% if disable_breadcrumb_questionnaire %} | ||
| <li class="breadcrumb-item">{{ questionnaire.name }}</li> | ||
| {% else %} | ||
| <li class="breadcrumb-item"><a href="{% url 'staff:questionnaire_edit' questionnaire.id %}">{{ questionnaire.name }}</a></li> | ||
| {% endif %} |
Member
There was a problem hiding this comment.
Why? I don't think the link is a problem, on the contrary, I think not having the link can only make it harder for people.
Not having the link requires additional logic in the template here, we need to add a new template argument, which we need to find a name for ("disable_breadcrumb_questionnaire" is rather misleading).
I'd say let's not go this way, just keep the link, or am I missing something?
| "-course__semester__created_at", "vote_start_datetime" | ||
| ) | ||
|
|
||
| evaluations_grouped_by_semester = unordered_groupby((e.course.semester, e) for e in evaluations) |
Member
There was a problem hiding this comment.
N+1 queries pattern -- let's prefetch the semester above (should be relatively simple)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2585