Repository navigation
In-place provider editor + in-UI copy dialogs - #2
Merged
Merged
Conversation
…ill fields on the list API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place provider editor + in-UI copy dialogs (work order: ash/provider-editor-ui)
What
RouteProviders):PATCH /api/providers/:id= remove the existing reference + re-insert the updated provider (no provider code touched for edits;Providers.createre-sanitizes the config viaserializeConfig). 404 on unknown id, 400 on invalid JSON/type. The list API (GET /api/providers) now also returnsurl+apiKey(only when present) so the editor can prefill.Modal.svelte(backdrop click + Escape close, a11y roles) andCopyModal.svelte(read-only field + Copy vianavigator.clipboardwith a legacy fallback for non-secure http contexts).InferenceProviderEditor.svelte: prefilled in-place editor (type / pool / url / api key). The id field is read-only — model aliases and in-flight state reference it.InferenceProviderCardgains an Edit button; the page holdseditingProviderstate and re-renders the provider list after save.window.prompt()copy dialogs (API key create, model alias copy) are now in-UICopyModals.Verification
mvn packagegreen (Svelte build included);svelte-check0 errors / 0 warnings.Branch base:
main@ bb2bf8a. (Concurrency fields are onash/pool-concurrency/ PR #1 — not on this branch by design.)~Ash