perl_matcher: replace vtable dispatch with switch-case in match_all_s… - #1
Closed
e4d08 wants to merge 1 commit into
Closed
perl_matcher: replace vtable dispatch with switch-case in match_all_s…#1e4d08 wants to merge 1 commit into
e4d08 wants to merge 1 commit into
Conversation
…tates and unwind Remove static arrays of member function pointers (s_match_vtable, s_unwind_table) and replace them with switch-case dispatch in match_all_states() and unwind(). This eliminates static data that could cause runtime initialization issues on some compilers, and improves clarity. Also replace magic number arguments to saved_state constructor with named enum values from saved_state_type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tates and unwind
Remove static arrays of member function pointers (s_match_vtable, s_unwind_table) and replace them with switch-case dispatch in match_all_states() and unwind(). This eliminates static data that could cause runtime initialization issues on some compilers, and improves clarity.
Also replace magic number arguments to saved_state constructor with named enum values from saved_state_type.