Skip to content

Fix bug that allows generators to retrofit years after retirement - #370

Open
mckennapep wants to merge 1 commit into
mainfrom
bug-369-retrofits
Open

Fix bug that allows generators to retrofit years after retirement#370
mckennapep wants to merge 1 commit into
mainfrom
bug-369-retrofits

Conversation

@mckennapep

@mckennapep mckennapep commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.61%. Comparing base (a66bacd) to head (7d93b71).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   88.64%   88.61%   -0.03%     
==========================================
  Files          56       56              
  Lines        6552     6555       +3     
==========================================
+ Hits         5808     5809       +1     
- Misses        744      746       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mckennapep
mckennapep requested a review from ajsbergman August 12, 2026 22:13
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Benchmark result

Judge result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmarks:
    • Target: 12 Aug 2026 - 22:09
    • Baseline: 12 Aug 2026 - 22:14
  • Package commits:
  • Julia commits:
    • Target: a2b1190
    • Baseline: a2b1190
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Brackets display tolerances for the benchmark estimates. Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["get_generator"] 1.09 (5%) ❌ 1.00 (1%)
["get_plnom"] 1.15 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.10.11
Commit a2b11907d7b (2026-03-09 14:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 24.04.4 LTS
  uname: Linux 6.17.0-1020-azure #20~24.04.1-Ubuntu SMP Fri Jun 19 20:09:14 UTC 2026 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3236 MHz       1632 s          0 s        107 s       3402 s          0 s
       #2  3244 MHz       2153 s          0 s        126 s       2850 s          0 s
       #3  3251 MHz       2168 s          0 s        135 s       2816 s          0 s
       #4  3246 MHz       2174 s          0 s        110 s       2836 s          0 s
  Memory: 15.614948272705078 GB (12968.21484375 MB free)
  Uptime: 518.03 sec
  Load Avg:  1.04  1.41  0.85
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.11
Commit a2b11907d7b (2026-03-09 14:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 24.04.4 LTS
  uname: Linux 6.17.0-1020-azure #20~24.04.1-Ubuntu SMP Fri Jun 19 20:09:14 UTC 2026 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3242 MHz       1961 s          0 s        121 s       5928 s          0 s
       #2  3251 MHz       3386 s          0 s        153 s       4464 s          0 s
       #3  3245 MHz       2524 s          0 s        150 s       5316 s          0 s
       #4  3231 MHz       3345 s          0 s        130 s       4518 s          0 s
  Memory: 15.614948272705078 GB (12739.55078125 MB free)
  Uptime: 805.81 sec
  Load Avg:  1.01  1.19  0.92
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 12 Aug 2026 - 22:09
  • Package commit: 2e7da15
  • Julia commit: a2b1190
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 95.728 ns (5%) 32 bytes (1%) 2
["get_generator"] 49.152 ns (5%) 48 bytes (1%) 1
["get_plnom"] 108.833 ns (5%) 48 bytes (1%) 3
["read_data"] 31.431 ms (5%) 10.94 MiB (1%) 315597
["run_e4st"] 471.360 ms (5%) 318.355 ms 109.89 MiB (1%) 659896
["setup_model"] 1.062 s (5%) 199.700 ms 710.20 MiB (1%) 10403644

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.10.11
Commit a2b11907d7b (2026-03-09 14:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 24.04.4 LTS
  uname: Linux 6.17.0-1020-azure #20~24.04.1-Ubuntu SMP Fri Jun 19 20:09:14 UTC 2026 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3236 MHz       1632 s          0 s        107 s       3402 s          0 s
       #2  3244 MHz       2153 s          0 s        126 s       2850 s          0 s
       #3  3251 MHz       2168 s          0 s        135 s       2816 s          0 s
       #4  3246 MHz       2174 s          0 s        110 s       2836 s          0 s
  Memory: 15.614948272705078 GB (12968.21484375 MB free)
  Uptime: 518.03 sec
  Load Avg:  1.04  1.41  0.85
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 12 Aug 2026 - 22:14
  • Package commit: a66bacd
  • Julia commit: a2b1190
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 91.611 ns (5%) 32 bytes (1%) 2
["get_generator"] 44.994 ns (5%) 48 bytes (1%) 1
["get_plnom"] 94.345 ns (5%) 48 bytes (1%) 3
["read_data"] 31.073 ms (5%) 10.94 MiB (1%) 315597
["run_e4st"] 485.330 ms (5%) 329.163 ms 109.89 MiB (1%) 659896
["setup_model"] 1.036 s (5%) 176.485 ms 710.20 MiB (1%) 10403644

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.10.11
Commit a2b11907d7b (2026-03-09 14:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 24.04.4 LTS
  uname: Linux 6.17.0-1020-azure #20~24.04.1-Ubuntu SMP Fri Jun 19 20:09:14 UTC 2026 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3242 MHz       1961 s          0 s        121 s       5928 s          0 s
       #2  3251 MHz       3386 s          0 s        153 s       4464 s          0 s
       #3  3245 MHz       2524 s          0 s        150 s       5316 s          0 s
       #4  3231 MHz       3345 s          0 s        130 s       4518 s          0 s
  Memory: 15.614948272705078 GB (12739.55078125 MB free)
  Uptime: 805.81 sec
  Load Avg:  1.01  1.19  0.92
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture:                            x86_64
CPU op-mode(s):                          32-bit, 64-bit
Address sizes:                           48 bits physical, 48 bits virtual
Byte Order:                              Little Endian
CPU(s):                                  4
On-line CPU(s) list:                     0-3
Vendor ID:                               AuthenticAMD
Model name:                              AMD EPYC 7763 64-Core Processor
CPU family:                              25
Model:                                   1
Thread(s) per core:                      2
Core(s) per socket:                      2
Socket(s):                               1
Stepping:                                1
BogoMIPS:                                4890.85
Flags:                                   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves user_shstk clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                          AMD-V
Hypervisor vendor:                       Microsoft
Virtualization type:                     full
L1d cache:                               64 KiB (2 instances)
L1i cache:                               64 KiB (2 instances)
L2 cache:                                1 MiB (2 instances)
L3 cache:                                32 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-3
Vulnerability Gather data sampling:      Not affected
Vulnerability Ghostwrite:                Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Old microcode:             Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass:         Vulnerable
Vulnerability Spectre v1:                Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Vulnerable: No microcode
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@ajsbergman

ajsbergman commented Aug 13, 2026

Copy link
Copy Markdown

Deleted a comment I want to think through more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajsbergman ajsbergman Awaiting requested review from ajsbergman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mckennapep @ajsbergman